Don't serialize the GitHub chip's "Loading..." placeholder title#3533
Open
luke-belton wants to merge 1 commit into
Open
Don't serialize the GitHub chip's "Loading..." placeholder title#3533luke-belton wants to merge 1 commit into
luke-belton wants to merge 1 commit into
Conversation
A pasted GitHub PR/issue URL inserts a chip titled "Loading..." until the real title is fetched. If the message is sent before the fetch resolves, the placeholder was serialized into the message as title="Loading..." and displayed forever. Serialize an unresolved chip with an empty title instead, matching the failed-fetch fallback. Generated-By: PostHog Code Task-Id: de8bff5b-1b4d-4033-b56b-62c895c8ab71
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
luke-belton
marked this pull request as ready for review
July 17, 2026 10:19
Contributor
|
Reviews (1): Last reviewed commit: "Don't serialize the GitHub chip's "Loadi..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pasting a GitHub PR/issue URL into the message editor inserts a chip labeled
#<n> - Loading...while the real title is fetched. If the message is sent before the fetch resolves (or the fetch silently fails at the wrong moment), the placeholder is serialized into the message astitle="Loading..."and rendered that way forever - e.g.<github_pr number="71827" title="Loading..." url="..." />showing up in an agent conversation.Changes
GITHUB_REF_PLACEHOLDER_TITLEincontent.ts(single source of truth, used bybuildGithubRefPlaceholderChip).contentToXmlnow serializes a still-unresolved chip withtitle="", the same shape as the existing failed-fetch fallback (#<n>labels), which the parser already round-trips as a title-less chip.How did you test this?
content.test.tsthat serializes a chip built bybuildGithubRefPlaceholderChipand asserts the placeholder does not leak (this also pins the builder and serializer to the same constant).pnpm --filter @posthog/core test- 213 files / 2415 tests pass.pnpm --filter @posthog/core typecheckandbiome lint packages/core- clean.Automatic notifications
Created with PostHog Code